Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix user resource #19366

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix user resource #19366

merged 2 commits into from
Sep 18, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Sep 14, 2023

fix the user resrouce defination of user api

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fix the user resrouce defination of user api

Signed-off-by: wang yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #19366 (0bb0fe3) into main (26a4f6e) will increase coverage by 0.03%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19366      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.03%     
==========================================
  Files         988      988              
  Lines      108688   108688              
  Branches     2752     2752              
==========================================
+ Hits        73311    73354      +43     
+ Misses      31437    31393      -44     
- Partials     3940     3941       +1     
Flag Coverage Δ
unittests 67.49% <16.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/server/v2.0/handler/user.go 14.68% <16.66%> (-1.52%) ⬇️

... and 11 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/update Update or Fix label Sep 16, 2023
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 4051b2b into goharbor:main Sep 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants