Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hide version property if the value is undefined #19395

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Sep 26, 2023

1.Related issue #19391

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1.Related issue goharbor#19391

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #19395 (426ede6) into main (3338f27) will decrease coverage by 22.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19395       +/-   ##
===========================================
- Coverage   67.45%   44.85%   -22.60%     
===========================================
  Files         988      244      -744     
  Lines      108732    13416    -95316     
  Branches     2752     2752               
===========================================
- Hits        73341     6018    -67323     
+ Misses      31444     7093    -24351     
+ Partials     3947      305     -3642     
Flag Coverage Δ
unittests 44.85% <ø> (-22.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 746 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit d0322df into goharbor:main Sep 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants