Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change fixed_version to package_version in query dangerous CVE sql #19397

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Sep 26, 2023

fixes #19391

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner September 26, 2023 13:32
@stonezdj stonezdj added the release-note/update Update or Fix label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #19397 (f7466ff) into main (1f975ed) will decrease coverage by 22.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19397       +/-   ##
===========================================
- Coverage   67.47%   44.89%   -22.59%     
===========================================
  Files         988      244      -744     
  Lines      108732    13416    -95316     
  Branches     2752     2752               
===========================================
- Hits        73368     6023    -67345     
+ Misses      31418     7089    -24329     
+ Partials     3946      304     -3642     
Flag Coverage Δ
unittests 44.89% <ø> (-22.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23sep26_fix_version branch from 22e2390 to e46977e Compare October 11, 2023 02:25
@stonezdj stonezdj enabled auto-merge (squash) October 11, 2023 07:02
  fixes goharbor#19391

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23sep26_fix_version branch from e46977e to f7466ff Compare October 11, 2023 07:03
@stonezdj stonezdj merged commit 663d0b8 into goharbor:main Oct 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The package version in the Top 5 Most Dangerous CVEs in Security Hub is shown as undefined
5 participants