Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(cherry-pick) Change fixed_version to package_version #19432

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 11, 2023

fixes #19391

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#19391

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner October 11, 2023 02:28
@stonezdj stonezdj assigned wy65701436 and chlins and unassigned wy65701436, zyyw and chlins Oct 11, 2023
@stonezdj stonezdj changed the title Change fixed_version to package_version (cherry-pick) Change fixed_version to package_version Oct 11, 2023
@stonezdj stonezdj added release-note/docs Docs changes(made and needed) release-note/update Update or Fix target/2.9.1 and removed release-note/docs Docs changes(made and needed) labels Oct 11, 2023
@stonezdj stonezdj enabled auto-merge (squash) October 11, 2023 02:30
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #19432 (c6c5975) into release-2.9.0 (6f85d59) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19432      +/-   ##
=================================================
+ Coverage          67.38%   67.40%   +0.01%     
=================================================
  Files                993      993              
  Lines             108921   108921              
  Branches            2752     2752              
=================================================
+ Hits               73396    73414      +18     
+ Misses             31580    31558      -22     
- Partials            3945     3949       +4     
Flag Coverage Δ
unittests 67.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/securityhub/dao/security.go 59.60% <ø> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 82c24ee into goharbor:release-2.9.0 Oct 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants