Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

subject: fix missing media type recognition for nydus #19453

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

imeoer
Copy link
Contributor

@imeoer imeoer commented Oct 17, 2023

Comprehensive Summary of your change

Nydus images are compatible with both docker scheme v2 and OCI image spec v1 types of config media type:

- application/vnd.oci.image.config.v1+json
- application/vnd.docker.container.image.v1+json

The patch fixes the media type recognition on the accessory type check.

Issue being fixed

Fixes #19452

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@imeoer imeoer requested a review from a team as a code owner October 17, 2023 01:52
Nydus images are compatible with both docker scheme v2 and OCI image spec v1
types of config media type:

  - application/vnd.oci.image.config.v1+json
  - application/vnd.docker.container.image.v1+json

The patch fixes the media type recognition on the accessory type check.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer force-pushed the fix-nydus-media-type branch from 0d2ae0f to 4d2096c Compare October 17, 2023 01:52
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #19453 (47c6a2e) into main (84a85fb) will decrease coverage by 25.83%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19453       +/-   ##
===========================================
- Coverage   70.62%   44.79%   -25.83%     
===========================================
  Files         744      244      -500     
  Lines       95316    13416    -81900     
  Branches        0     2752     +2752     
===========================================
- Hits        67319     6010    -61309     
+ Misses      24356     7100    -17256     
+ Partials     3641      306     -3335     
Flag Coverage Δ
unittests 44.79% <ø> (-25.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 988 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 13f4fca into goharbor:main Oct 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated nydus image can't be recognized
4 participants