Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bump golang to 1.21.3 #19504

Merged
merged 1 commit into from
Oct 31, 2023
Merged

bump golang to 1.21.3 #19504

merged 1 commit into from
Oct 31, 2023

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Oct 30, 2023
@MinerYang MinerYang requested a review from a team as a code owner October 30, 2023 06:40
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #19504 (af03dda) into main (064a109) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19504   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         989      989           
  Lines      108836   108836           
  Branches     2752     2752           
=======================================
+ Hits        73403    73407    +4     
+ Misses      31471    31467    -4     
  Partials     3962     3962
Flag Coverage Δ
unittests 67.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@MinerYang MinerYang changed the title bump golang to 1.21.3 [WIP]bump golang to 1.21.3 Oct 30, 2023
@MinerYang MinerYang closed this Oct 30, 2023
@MinerYang MinerYang reopened this Oct 31, 2023
@MinerYang MinerYang force-pushed the bump_golang_1.21.3_main branch 2 times, most recently from 61f06cb to 2e54fb6 Compare October 31, 2023 02:30
@MinerYang
bump golang to 1.21.3
af03dda 
update ut mock

update go mod

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang force-pushed the bump_golang_1.21.3_main branch from 2e54fb6 to af03dda Compare October 31, 2023 02:31
@MinerYang MinerYang changed the title [WIP]bump golang to 1.21.3 bump golang to 1.21.3 Oct 31, 2023
@MinerYang MinerYang merged commit 193b00b into goharbor:main Oct 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@OrlinVasilev OrlinVasilev OrlinVasilev approved these changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@zyyw zyyw

@OrlinVasilev OrlinVasilev

@YangJiao0817 YangJiao0817

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MinerYang @zyyw @OrlinVasilev @YangJiao0817 @Vad1mo @stonezdj @wy65701436 @AllForNothing @chlins