Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a tooltip for the replication rule #19509

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Oct 31, 2023

  1. Fixes Add tooltips for event based replication #19371

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #19509 (3552a48) into main (2916d09) will increase coverage by 22.56%.
The diff coverage is n/a.

❗ Current head 3552a48 differs from pull request most recent head db728df. Consider uploading reports for the commit db728df to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19509       +/-   ##
===========================================
+ Coverage   44.89%   67.45%   +22.56%     
===========================================
  Files         244      989      +745     
  Lines       13417   108836    +95419     
  Branches     2752     2752               
===========================================
+ Hits         6023    73419    +67396     
- Misses       7088    31453    +24365     
- Partials      306     3964     +3658     
Flag Coverage Δ
unittests 67.45% <ø> (+22.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 749 files with indirect coverage changes

@AllForNothing AllForNothing force-pushed the replication-tooltip branch 2 times, most recently from b098f8a to 3552a48 Compare October 31, 2023 08:45
@AllForNothing AllForNothing enabled auto-merge (squash) October 31, 2023 08:46
1. Fixes goharbor#19371

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit f75a2f9 into goharbor:main Oct 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltips for event based replication
7 participants