Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a placeholder to the cards for the security-hub #19536

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 6, 2023

  1. Fixes task 3 of Update style for the UI #19249
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner November 6, 2023 04:01
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #19536 (e622464) into main (7718134) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19536      +/-   ##
==========================================
+ Coverage   45.25%   45.32%   +0.07%     
==========================================
  Files         244      244              
  Lines       13320    13323       +3     
  Branches     2720     2720              
==========================================
+ Hits         6028     6039      +11     
+ Misses       6990     6981       -9     
- Partials      302      303       +1     
Flag Coverage Δ
unittests 45.32% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ability-summary/vulnerability-summary.component.ts 69.23% <100.00%> (+2.56%) ⬆️

... and 4 files with indirect coverage changes

@AllForNothing AllForNothing enabled auto-merge (squash) November 6, 2023 04:11
@AllForNothing AllForNothing force-pushed the placeholder branch 2 times, most recently from 7062cc5 to 030d9bb Compare November 6, 2023 04:12
1. Related issue goharbor#19249

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 30730c6 into goharbor:main Nov 15, 2023
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Related issue goharbor#19249

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants