Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add notation sign artifact API test case #19549

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

YangJiao0817
Copy link
Member

Fix #19545

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#19545

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #19549 (01fca7f) into main (b8f65bb) will decrease coverage by 22.66%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19549       +/-   ##
===========================================
- Coverage   67.50%   44.85%   -22.66%     
===========================================
  Files         988      243      -745     
  Lines      108777    13354    -95423     
  Branches     2737     2737               
===========================================
- Hits        73433     5990    -67443     
+ Misses      31379     7060    -24319     
+ Partials     3965      304     -3661     
Flag Coverage Δ
unittests 44.85% <ø> (-22.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 749 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) November 7, 2023 08:05
@YangJiao0817 YangJiao0817 merged commit 35a605e into goharbor:main Nov 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notation sign artifact API test case
6 participants