Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update the name checking for the robot account #19645

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 29, 2023

  1. Fixes Robot Account UI checking logic needs to be revised #19612

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #19645 (88bf660) into main (3c56f2d) will decrease coverage by 22.27%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19645       +/-   ##
===========================================
- Coverage   67.55%   45.28%   -22.27%     
===========================================
  Files         991      244      -747     
  Lines      109168    13331    -95837     
  Branches     2719     2719               
===========================================
- Hits        73748     6037    -67711     
+ Misses      31451     6991    -24460     
+ Partials     3969      303     -3666     
Flag Coverage Δ
unittests 45.28% <0.00%> (-22.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...em-robot-accounts/new-robot/new-robot.component.ts 21.27% <0.00%> (-0.35%) ⬇️
...ect/robot-account/add-robot/add-robot.component.ts 21.66% <0.00%> (-0.56%) ⬇️

... and 751 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. Fixes goharbor#19612

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@AllForNothing AllForNothing enabled auto-merge (squash) December 5, 2023 02:23
@AllForNothing AllForNothing merged commit 7fee99b into goharbor:main Dec 5, 2023
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Fixes goharbor#19612

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot Account UI checking logic needs to be revised
5 participants