Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update deletion for index type of accessory #20073

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Update deletion for index type of accessory #20073

merged 1 commit into from
Mar 13, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Mar 1, 2024 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner March 1, 2024 02:50
@MinerYang MinerYang force-pushed the fix_delete_index_accessory branch from 9ab1321 to fe8d0c6 Compare March 5, 2024 01:59
@MinerYang MinerYang mentioned this pull request Mar 13, 2024
Closed
@MinerYang
update delete for index accessory
95488b3 
Signed-off-by: yminer <yminer@vmware.com>

revert error code

update lint and comments
@MinerYang MinerYang force-pushed the fix_delete_index_accessory branch from fe8d0c6 to 95488b3 Compare March 13, 2024 05:33
@MinerYang MinerYang added the release-note/update Update or Fix label Mar 13, 2024
@MinerYang MinerYang changed the title update delete for index accessory Update deletion for index type of accessory Mar 13, 2024
wy65701436
wy65701436 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit f7a3392 into goharbor:main Mar 13, 2024
10 of 11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

Labels
kind/distribution-spec release-note/update Update or Fix target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MinerYang @stonezdj @wy65701436 @Vad1mo @OrlinVasilev