Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add api test case for quota sorting #20209

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Apr 2, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19875

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added release-note/infra Infra related changes e.g. release, test, ship etc... target/2.11.0 labels Apr 2, 2024
@zyyw zyyw requested a review from a team as a code owner April 2, 2024 08:40
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (b7b8847) to head (7aeb4dc).
Report is 113 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20209      +/-   ##
==========================================
- Coverage   67.56%   67.50%   -0.07%     
==========================================
  Files         991      998       +7     
  Lines      109181   110081     +900     
  Branches     2719     2724       +5     
==========================================
+ Hits        73768    74307     +539     
- Misses      31449    31790     +341     
- Partials     3964     3984      +20     
Flag Coverage Δ
unittests 67.50% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 508 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit c12064d into goharbor:main Apr 7, 2024
17 of 18 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc... target/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Quota Sorting API test case
5 participants