Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[cherry-pick] Allow empty path in redirect_url #20237

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[cherry-pick] Allow empty path in redirect_url #20237

merged 1 commit into from
Apr 8, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Apr 8, 2024

fixes #20226

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Allow empty path in redirect_url
3e64aac 
  fixes goharbor#20226

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner April 8, 2024 02:17
@stonezdj stonezdj changed the title Allow empty path in redirect_url [cherry-pick] Allow empty path in redirect_url Apr 8, 2024
wy65701436
wy65701436 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit a823845 into goharbor:release-2.10.0 Apr 8, 2024
12 of 13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

@chlins chlins

Labels
release-note/update Update or Fix target/2.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stonezdj @wy65701436 @zyyw @chlins