-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow empty path in redirect_url #20238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20238 +/- ##
===========================================
- Coverage 67.56% 45.29% -22.27%
===========================================
Files 991 244 -747
Lines 109181 13345 -95836
Branches 2719 2724 +5
===========================================
- Hits 73768 6045 -67723
+ Misses 31449 6998 -24451
+ Partials 3964 302 -3662
Flags with carried forward coverage won't be shown. Click here to find out more. |
zyyw
approved these changes
Apr 8, 2024
wy65701436
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b4afcc5
to
18290bc
Compare
Vad1mo
approved these changes
Apr 8, 2024
fixes goharbor#20226 Signed-off-by: stonezdj <daojunz@vmware.com>
18290bc
to
216de7c
Compare
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Apr 9, 2024
fixes goharbor#20226 Signed-off-by: stonezdj <daojunz@vmware.com> Co-authored-by: stonezdj <daojunz@vmware.com>
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Apr 9, 2024
fixes goharbor#20226 Signed-off-by: stonezdj <daojunz@vmware.com> Co-authored-by: stonezdj <daojunz@vmware.com> Signed-off-by: wang yan <wangyan@vmware.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for redirect to other sites with OIDC login and empty redirect_url parameter see #20226
Comprehensive Summary of your change
Issue being fixed
Fixes #20226
Please indicate you've done the following: