Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow empty path in redirect_url #20238

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Apr 8, 2024

Fix for redirect to other sites with OIDC login and empty redirect_url parameter see #20226

Comprehensive Summary of your change

Issue being fixed

Fixes #20226

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 8, 2024 02:18
@stonezdj stonezdj assigned stonezdj and unassigned Vad1mo, zyyw and chlins Apr 8, 2024
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 8, 2024
@stonezdj stonezdj requested review from wy65701436 and zyyw April 8, 2024 02:18
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (b7b8847) to head (216de7c).
Report is 116 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20238       +/-   ##
===========================================
- Coverage   67.56%   45.29%   -22.27%     
===========================================
  Files         991      244      -747     
  Lines      109181    13345    -95836     
  Branches     2719     2724        +5     
===========================================
- Hits        73768     6045    -67723     
+ Misses      31449     6998    -24451     
+ Partials     3964      302     -3662     
Flag Coverage Δ
unittests 45.29% <ø> (-22.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1235 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24apr08_allow_empty_url branch from b4afcc5 to 18290bc Compare April 8, 2024 04:53
@stonezdj stonezdj enabled auto-merge (squash) April 8, 2024 04:53
  fixes goharbor#20226

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 24apr08_allow_empty_url branch from 18290bc to 216de7c Compare April 9, 2024 01:47
@stonezdj stonezdj merged commit 96ba34a into goharbor:main Apr 9, 2024
11 of 12 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
fixes goharbor#20226

Signed-off-by: stonezdj <daojunz@vmware.com>
Co-authored-by: stonezdj <daojunz@vmware.com>
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
fixes goharbor#20226

Signed-off-by: stonezdj <daojunz@vmware.com>
Co-authored-by: stonezdj <daojunz@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot redirect to other site with OIDC login and empty redirect_url parameter
5 participants