Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bump golang to 1.22.2 #20256

Merged
merged 1 commit into from
Apr 12, 2024
Merged

bump golang to 1.22.2 #20256

merged 1 commit into from
Apr 12, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Apr 10, 2024
@MinerYang MinerYang requested a review from a team as a code owner April 10, 2024 09:11
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.39%. Comparing base (b7b8847) to head (5302bcd).
Report is 129 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20256      +/-   ##
==========================================
- Coverage   67.56%   66.39%   -1.17%     
==========================================
  Files         991     1039      +48     
  Lines      109181   112536    +3355     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74721     +953     
- Misses      31449    33787    +2338     
- Partials     3964     4028      +64     
Flag Coverage Δ
unittests 66.39% <ø> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 558 files with indirect coverage changes

@MinerYang MinerYang force-pushed the bump_golang_1.22.2 branch 4 times, most recently from 101d5ce to eed19a6 Compare April 10, 2024 09:50
@MinerYang MinerYang changed the title bump golang to 1.22.2 [WIP]bump golang to 1.22.2 Apr 10, 2024
@MinerYang MinerYang force-pushed the bump_golang_1.22.2 branch 5 times, most recently from 2653f58 to 8fba668 Compare April 11, 2024 06:11
@MinerYang MinerYang changed the title [WIP]bump golang to 1.22.2 bump golang to 1.22.2 Apr 11, 2024
@MinerYang MinerYang force-pushed the bump_golang_1.22.2 branch 2 times, most recently from 6ffe0bb to 8da72e6 Compare April 11, 2024 08:44
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the bump_golang_1.22.2 branch from 117d396 to 4c0ef26 Compare April 12, 2024 04:33
Signed-off-by: yminer <yminer@vmware.com>

replace go get to go install

update go.mod
@MinerYang MinerYang force-pushed the bump_golang_1.22.2 branch from e8c52b0 to 5302bcd Compare April 12, 2024 05:08
@MinerYang MinerYang merged commit 7e8032b into goharbor:main Apr 12, 2024
17 of 18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants