Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update the image reference format for audit log when pulling image #20278

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Apr 15, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20230

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.18%. Comparing base (b7b8847) to head (61d9e1f).
Report is 136 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20278      +/-   ##
==========================================
+ Coverage   67.56%   69.18%   +1.61%     
==========================================
  Files         991      793     -198     
  Lines      109181    98973   -10208     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68471    -5297     
+ Misses      31449    26792    -4657     
+ Partials     3964     3710     -254     
Flag Coverage Δ
unittests 69.18% <0.00%> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/event/topic.go 6.47% <0.00%> (ø)

... and 311 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw force-pushed the al-reference-format branch from f9b40c6 to bccd626 Compare April 16, 2024 01:51
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the al-reference-format branch from bccd626 to 61d9e1f Compare April 16, 2024 02:18
@wy65701436 wy65701436 merged commit 91efec1 into goharbor:main Apr 16, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid image reference format in Logs Portal
6 participants