Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename scan request type #20288

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 17, 2024 01:44
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.14%. Comparing base (b7b8847) to head (36c8123).
Report is 141 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20288       +/-   ##
===========================================
- Coverage   67.56%   46.14%   -21.43%     
===========================================
  Files         991      246      -745     
  Lines      109181    13565    -95616     
  Branches     2719     2781       +62     
===========================================
- Hits        73768     6259    -67509     
+ Misses      31449     6989    -24460     
+ Partials     3964      317     -3647     
Flag Coverage Δ
unittests 46.14% <ø> (-21.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1237 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24apr17_refactor_scan_type branch from 076b265 to a552680 Compare April 17, 2024 08:44
@stonezdj stonezdj enabled auto-merge (squash) April 17, 2024 08:46
@stonezdj stonezdj force-pushed the 24apr17_refactor_scan_type branch 2 times, most recently from 49d6636 to 1887d6b Compare April 17, 2024 08:55
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24apr17_refactor_scan_type branch from 1887d6b to 36c8123 Compare April 17, 2024 09:16
@stonezdj stonezdj merged commit fb2e004 into goharbor:main Apr 17, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants