Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

skip to log scan sbom accessory for sbom accessory #20290

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 17, 2024 07:13
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.18%. Comparing base (b7b8847) to head (b49fa94).
Report is 142 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20290       +/-   ##
===========================================
- Coverage   67.56%   46.18%   -21.38%     
===========================================
  Files         991      246      -745     
  Lines      109181    13565    -95616     
  Branches     2719     2781       +62     
===========================================
- Hits        73768     6265    -67503     
+ Misses      31449     6984    -24465     
+ Partials     3964      316     -3648     
Flag Coverage Δ
unittests 46.18% <ø> (-21.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1237 files with indirect coverage changes

@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Apr 17, 2024
@stonezdj stonezdj assigned wy65701436 and unassigned OrlinVasilev Apr 17, 2024
@stonezdj stonezdj removed the release-note/new-feature New Harbor Feature label Apr 17, 2024
@stonezdj stonezdj force-pushed the 24apr17_auto_scan_sbom_error branch from 24f792f to ae11049 Compare April 17, 2024 07:29
@stonezdj stonezdj changed the title skip to scan sbom accessory skip to log scan sbom accessory for sbom accessory Apr 17, 2024
@stonezdj stonezdj force-pushed the 24apr17_auto_scan_sbom_error branch from ae11049 to 8d05340 Compare April 17, 2024 08:41
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…BOM in webhook event

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24apr17_auto_scan_sbom_error branch from 8d05340 to b030d37 Compare April 17, 2024 13:28
@stonezdj stonezdj enabled auto-merge (squash) April 17, 2024 14:15
@stonezdj stonezdj merged commit 2ea7d09 into goharbor:main Apr 17, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants