Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: update controller.go #20297

Merged
merged 2 commits into from
Apr 18, 2024
Merged

refactor: update controller.go #20297

merged 2 commits into from
Apr 18, 2024

Conversation

eltociear
Copy link
Contributor

Comprehensive Summary of your change

minor fix

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

minor fix

Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
@eltociear eltociear requested a review from a team as a code owner April 17, 2024 14:16
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang added the release-note/update Update or Fix label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (b7b8847) to head (46dafde).
Report is 143 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20297      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.21%     
==========================================
  Files         991     1041      +50     
  Lines      109181   112740    +3559     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74817    +1049     
- Misses      31449    33880    +2431     
- Partials     3964     4043      +79     
Flag Coverage Δ
unittests 66.36% <ø> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 562 files with indirect coverage changes

@wy65701436 wy65701436 merged commit 4fd11ce into goharbor:main Apr 18, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants