Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong values shown for the columns of support_sbom and support_vulnerability in scanner list #20308

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

xuelichao
Copy link
Contributor

Wrong values shown for the columns of support_sbom and support_vulnerability in scanner list

Currently, the values is read from scanner.metadata.capabilities.

UI needs to read the value from scanner.capabilities['support_sbom'] and scanner.capabilities['support_vulnerability']

Issue being fixed

Fixes #20307

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label Apr 19, 2024
@xuelichao xuelichao self-assigned this Apr 19, 2024
@xuelichao xuelichao requested a review from a team as a code owner April 19, 2024 09:12
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.34%. Comparing base (b7b8847) to head (2cc5b7c).
Report is 149 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20308      +/-   ##
==========================================
- Coverage   67.56%   66.34%   -1.23%     
==========================================
  Files         991     1042      +51     
  Lines      109181   112940    +3759     
  Branches     2719     2827     +108     
==========================================
+ Hits        73768    74927    +1159     
- Misses      31449    33961    +2512     
- Partials     3964     4052      +88     
Flag Coverage Δ
unittests 66.34% <ø> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 565 files with indirect coverage changes

@zyyw zyyw added area/ui release-note/update Update or Fix target/2.11.0 and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels Apr 22, 2024
…nerability in scanner list

Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao merged commit e7fce62 into goharbor:main Apr 22, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong values shown for the columns of support_sbom and support_vulnerability in scanner list
6 participants