Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update image reference to "@" in audit log when pushing & deleting images #20348

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Apr 24, 2024

Thank you for contributing to Harbor!

Screenshot 2024-04-24 at 2 59 54 PM

Comprehensive Summary of your change

Issue being fixed

Fixes #20341

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…ng images

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.37%. Comparing base (b7b8847) to head (c3ab410).
Report is 154 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20348      +/-   ##
==========================================
- Coverage   67.56%   66.37%   -1.19%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113026    +3845     
  Branches     2719     2827     +108     
==========================================
+ Hits        73768    75021    +1253     
- Misses      31449    33954    +2505     
- Partials     3964     4051      +87     
Flag Coverage Δ
unittests 66.37% <0.00%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/event/topic.go 6.47% <0.00%> (ø)

... and 565 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zyyw zyyw merged commit 2af02f3 into goharbor:main Apr 24, 2024
13 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit log digest format inconsistent
5 participants