Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add scanner info and report_id to sbom_overview on listing artifact #20358

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

stonezdj
Copy link
Contributor

Add scan_status and report_id when scan has a failed task

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  Add scan_status and report_id when scan has a failed task

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested a review from a team as a code owner April 25, 2024 01:35
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 25, 2024
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned Vad1mo, chlins and MinerYang Apr 25, 2024
@stonezdj stonezdj requested review from zyyw and wy65701436 April 25, 2024 01:36
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 66.37%. Comparing base (b7b8847) to head (8208885).
Report is 155 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20358      +/-   ##
==========================================
- Coverage   67.56%   66.37%   -1.19%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113053    +3872     
  Branches     2719     2827     +108     
==========================================
+ Hits        73768    75041    +1273     
- Misses      31449    33961    +2512     
- Partials     3964     4051      +87     
Flag Coverage Δ
unittests 66.37% <68.57%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/model/summary.go 0.00% <ø> (ø)
src/server/v2.0/handler/assembler/report.go 66.66% <88.88%> (ø)
src/pkg/scan/sbom/sbom.go 65.90% <75.00%> (ø)
src/controller/scan/base_controller.go 57.08% <55.55%> (-2.47%) ⬇️

... and 567 files with indirect coverage changes

Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stonezdj stonezdj merged commit ec8d692 into goharbor:main Apr 25, 2024
12 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants