-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add membership=true back for gitlab replication adapter #20400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20400 +/- ##
==========================================
- Coverage 67.56% 66.36% -1.20%
==========================================
Files 991 1042 +51
Lines 109181 113117 +3936
Branches 2719 2830 +111
==========================================
+ Hits 73768 75071 +1303
- Misses 31449 33986 +2537
- Partials 3964 4060 +96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lxShaDoWxl @chlins Could you please help to review it? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove could resolve the 500, but we need to figure out the meaning of search_namespaces.
@lxShaDoWxl Could you please kindly provide some insights on this? Although we have read through this doc (search by |
@lxShaDoWxl can you leave your comments? |
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20401
Please indicate you've done the following: