Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bump golang 1.22.3 #20433

Merged
merged 6 commits into from
May 16, 2024
Merged

bump golang 1.22.3 #20433

merged 6 commits into from
May 16, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang added the release-note/update Update or Fix label May 15, 2024
@MinerYang MinerYang requested a review from a team as a code owner May 15, 2024 08:05
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.35%. Comparing base (b7b8847) to head (b0cc2eb).
Report is 189 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20433      +/-   ##
==========================================
- Coverage   67.56%   66.35%   -1.22%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113164    +3983     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75089    +1321     
- Misses      31449    34011    +2562     
- Partials     3964     4064     +100     
Flag Coverage Δ
unittests 66.35% <ø> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 569 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang enabled auto-merge (squash) May 16, 2024 04:24
MinerYang added 2 commits May 16, 2024 05:15
Signed-off-by: yminer <yminer@vmware.com>
Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang disabled auto-merge May 16, 2024 06:24
@MinerYang MinerYang merged commit 2da4d58 into goharbor:main May 16, 2024
17 of 18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants