Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix-20459 Wrong sbom status displayed in UI #20464

Merged
merged 3 commits into from
May 21, 2024

Conversation

xuelichao
Copy link
Contributor

Thank you for contributing to Harbor!

Fix Wrong sbom status displayed in UI

Issue being fixed

Fixes #20459

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

xuelichao and others added 2 commits May 20, 2024 15:42
Signed-off-by: xuelichao <xuel@vmware.com>
Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao requested a review from a team as a code owner May 21, 2024 09:03
Signed-off-by: Lichao Xue <68891670+xuelichao@users.noreply.github.com>
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@acb9e17). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20464   +/-   ##
=================================================
  Coverage                  ?   69.12%           
=================================================
  Files                     ?      795           
  Lines                     ?    99416           
  Branches                  ?        0           
=================================================
  Hits                      ?    68726           
  Misses                    ?    26951           
  Partials                  ?     3739           
Flag Coverage Δ
unittests 69.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 15e7a44 into goharbor:release-2.11.0 May 21, 2024
12 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants