Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cherry-pick] Separate the execution vendor type sbom from image_scan #20508

Merged
merged 1 commit into from
May 29, 2024

Conversation

stonezdj
Copy link
Contributor

Add vendor type SBOM for execution
fixes #20495

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  Add vendor type SBOM for execution
  fixes goharbor#20495

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested a review from a team as a code owner May 29, 2024 06:40
@stonezdj stonezdj added the release-note/update Update or Fix label May 29, 2024
@stonezdj stonezdj changed the title Separate the execution vendor type sbom from image_scan [cherry-pick] Separate the execution vendor type sbom from image_scan May 29, 2024
@stonezdj stonezdj requested review from zyyw and wy65701436 May 29, 2024 06:42
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-2.11.0@14f9af0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20508   +/-   ##
=================================================
  Coverage                  ?   66.24%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113486           
  Branches                  ?     2842           
=================================================
  Hits                      ?    75179           
  Misses                    ?    34200           
  Partials                  ?     4107           
Flag Coverage Δ
unittests 66.24% <69.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/scan/base_controller.go 56.82% <100.00%> (ø)
src/jobservice/job/known_jobs.go 0.00% <ø> (ø)
src/pkg/scan/handler.go 100.00% <ø> (ø)
src/pkg/scan/sbom/sbom.go 48.51% <0.00%> (ø)
src/pkg/scan/vulnerability/vul.go 56.68% <0.00%> (ø)

@stonezdj stonezdj merged commit 26eb63b into goharbor:release-2.11.0 May 29, 2024
14 of 15 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 29, 2024
…goharbor#20508)

Separate the execution vendor type sbom from image_scan

  Add vendor type SBOM for execution
  fixes goharbor#20495

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants