Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change the log message when PostScan failed. #20650

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20573
remove s from additions/sboms in the link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.25%. Comparing base (c8c11b4) to head (bfb5af8).
Report is 238 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20650       +/-   ##
===========================================
+ Coverage   45.36%   66.25%   +20.88%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75198    +69149     
- Misses       6983    34192    +27209     
- Partials      301     4111     +3810     
Flag Coverage Δ
unittests 66.25% <0.00%> (+20.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/model.go 40.00% <0.00%> (ø)
src/pkg/scan/job.go 31.55% <0.00%> (ø)

... and 1285 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24jun24_fix_log_msg branch from 62ce329 to e4a14f8 Compare July 2, 2024 06:22
  fixes goharbor#20573
  remove s from additions/sboms in the link

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24jun24_fix_log_msg branch from e4a14f8 to bfb5af8 Compare July 4, 2024 06:19
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit f86f1ce into goharbor:main Jul 4, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate log messege when push accessory fail
6 participants