Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JobService: fix for missing log data in jobservice DB logging #20684

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Jul 2, 2024

Comprehensive Summary of your change

Replaces #20549

Credits of the main fix: @nickhyoti (1st commit)

Issue being fixed

Fixes #20548

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

mohamedawnallah and others added 2 commits July 2, 2024 03:54
As per bug 20548, if DB logging is enabled for jobservice and the parameter is also set for maximum log size
the log data is not being returned and 'Clean Up->Show GC Logs' shows a blank page

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Co-authored-by: Nick Hindley <no-reply@example.com>
…ging

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (c8c11b4) to head (c469f9f).
Report is 237 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20684       +/-   ##
===========================================
+ Coverage   45.36%   66.24%   +20.88%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75193    +69144     
- Misses       6983    34198    +27215     
- Partials      301     4110     +3809     
Flag Coverage Δ
unittests 66.24% <100.00%> (+20.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/jobservice/logger/getter/db_getter.go 81.81% <100.00%> (ø)

... and 1286 files with indirect coverage changes

@chlins chlins added the release-note/update Update or Fix label Jul 3, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit cc1acc3 into goharbor:main Jul 4, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobservice: GC logs blank page when using DB logging
5 participants