Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cherry-pick] Change the log message when PostScan failed. #20699

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 4, 2024

fixes #20573
remove s from additions/sboms in the link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#20573
  remove s from additions/sboms in the link

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested a review from a team as a code owner July 4, 2024 09:26
@stonezdj stonezdj requested review from wy65701436 and zyyw July 4, 2024 09:26
@stonezdj stonezdj changed the title Change the log message when PostScan failed. [cherry-pick] Change the log message when PostScan failed. Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.11.0@82c9f9c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20699   +/-   ##
=================================================
  Coverage                  ?   66.23%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113486           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75166           
  Misses                    ?    34211           
  Partials                  ?     4109           
Flag Coverage Δ
unittests 66.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/model.go 40.00% <0.00%> (ø)
src/pkg/scan/job.go 31.55% <0.00%> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 3b49c97 into goharbor:release-2.11.0 Jul 4, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants