[WIP]update check docker compose #21076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yminer <miner.yang@broadcom.com>
MinerYang
added
the
release-note/ignore-for-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21076 +/- ##
===========================================
+ Coverage 45.36% 66.09% +20.72%
===========================================
Files 244 1049 +805
Lines 13333 114645 +101312
Branches 2719 2867 +148
===========================================
+ Hits 6049 75771 +69722
- Misses 6983 34735 +27752
- Partials 301 4139 +3838
Flags with carried forward coverage won't be shown. Click here to find out more. |
MinerYang
changed the title
cbandy
reviewed
Oct 25, 2024
| @@ -103,7 +103,7 @@ function check_docker { | |||
| } | |||
|
|
|||
| function check_dockercompose { | |||
| if [! docker compose version] &> /dev/null || [! docker-compose --version] &> /dev/null | |||
| if ! [docker compose version &> /dev/null] || ! [docker-compose --version &> /dev/null] | |||
There was a problem hiding this comment.
Suggested change
| if ! [docker compose version &> /dev/null] || ! [docker-compose --version &> /dev/null] | |
| if ! docker compose version &> /dev/null || ! docker-compose --version &> /dev/null |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: