Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix robot account creation issue #21313

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Dec 13, 2024

fixes #21251

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#21251

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner December 13, 2024 05:48
@wy65701436 wy65701436 added the release-note/update Update or Fix label Dec 13, 2024
@wy65701436 wy65701436 assigned stonezdj and unassigned Vad1mo and OrlinVasilev Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@6eea45d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21313   +/-   ##
=================================================
  Coverage                  ?   66.09%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114656           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75779           
  Misses                    ?    34729           
  Partials                  ?     4148           
Flag Coverage Δ
unittests 66.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/server/v2.0/handler/robot.go 13.20% <100.00%> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) December 13, 2024 06:01
@stonezdj stonezdj merged commit d1350cd into goharbor:release-2.12.0 Dec 13, 2024
14 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants