-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add dao and manager for audit log ext #21379
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21379 +/- ##
==========================================
+ Coverage 45.36% 46.30% +0.93%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6429 +380
- Misses 6983 7116 +133
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
484d4e2
to
c07a50e
Compare
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
c07a50e
to
fe6afee
Compare
Resource string `orm:"column(resource)" json:"resource"` | ||
Username string `orm:"column(username)" json:"username"` | ||
OpTime time.Time `orm:"column(op_time)" json:"op_time" sort:"default:desc"` | ||
Payload string `orm:"column(payload)" json:"payload"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we just leave it as empty for further use, so let's skip it in this model.
} | ||
|
||
// EventTypes defines the types of audit log event | ||
var EventTypes = []string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we put the EventTypes into DB model?
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: