-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update docs for co#tegration #301
Conversation
Signed-off-by: Abigail McCarthy <mabigail@vmware.com>
Setting this as draft because I still need to add screenshots. @wy65701436 Can you review if you have some time? I also had a few questions:
|
|
||
[SCREENSHOT OF ARTIFACT EXPANDED & ACCESSORY TABLE] | ||
|
||
### Delete Cosign signatures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also add comments that Harbor doesn't support cosign clean
to remove signature since it has to implement tag delete API which is not required by OCI distribution spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the tag delete API a part of cosign, or sigstore? just want to make sure i understand how its connected :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I mean, https://github.com/opencontainers/distribution-spec/blob/main/spec.md#content-management
Harbor doesn't choose to imple tag deletion, but cosign clean
is using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the docs to include this information
Thanks @a-mccarthy, should we also consider to add the following?
For example, if user chooses to GC untagged artifact, and given any signature has no tag, GC will also not remove it.
|
|
Signed-off-by: Abigail McCarthy <mabigail@vmware.com>
Signed-off-by: Abigail McCarthy <mabigail@vmware.com>
|
||
Note that Harbor's [garbage collection](../../administration/garbage-collection/) will not remove any signature individually. In Harbor, Cosign signatures are treated like any other OCI artifact, except from the perspective of the garbage collector which can't see accessory artifacts, like Cosign signatures. For example, if you configure garbage collection for untagged artifacts, Harbor's garbage collector will not remove any signatures without a tag. If the signed artifact is untagged, and matches the configured garbage collect rule, it and any associated signatures will be deleted. | ||
|
||
HHarbor doesn't support `cosign clean` to remove signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harbor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also add reason for why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i updated this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Abigail McCarthy <mabigail@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews @wy65701436 and @OrlinVasilev! |
Signed-off-by: Abigail McCarthy mabigail@vmware.com