Skip to content

feat(metric): add success, failure and submitted tasks #48

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

appleboy
Copy link
Member

type metric struct {
	busyWorkers    uint64
	successTasks   uint64
	failureTasks   uint64
	submittedTasks uint64
}

fix #47

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

type metric struct {
	busyWorkers    uint64
	successTasks   uint64
	failureTasks   uint64
	submittedTasks uint64
}

fix #47

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy added the enhancement New feature or request label Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #48 (167ef13) into master (8af744c) will decrease coverage by 1.04%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   85.81%   84.77%   -1.05%     
==========================================
  Files          10       10              
  Lines         416      440      +24     
==========================================
+ Hits          357      373      +16     
- Misses         54       62       +8     
  Partials        5        5              
Flag Coverage Δ
go-1.13 84.77% <94.73%> (-0.81%) ⬇️
go-1.14 84.77% <94.73%> (-0.81%) ⬇️
go-1.15 84.77% <94.73%> (-1.05%) ⬇️
go-1.16 84.77% <94.73%> (-0.81%) ⬇️
go-1.17 84.77% <94.73%> (-0.81%) ⬇️
go-1.18 84.77% <94.73%> (-0.81%) ⬇️
ubuntu-latest 84.77% <94.73%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
worker_empty.go 25.00% <ø> (-3.58%) ⬇️
worker_message.go 45.00% <ø> (-41.96%) ⬇️
worker_task.go 90.47% <ø> (+7.14%) ⬆️
queue.go 86.12% <93.33%> (-0.72%) ⬇️
metric.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af744c...167ef13. Read the comment docs.

@appleboy appleboy merged commit bfe4374 into master Mar 28, 2022
@appleboy appleboy deleted the metric branch March 28, 2022 04:24
@appleboy appleboy restored the metric branch January 25, 2025 05:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add SuccessTasks, FailureTasks and SubmittedTasks number in Metrics.
2 participants