Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(consumer): stop retry task #88

Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix(consumer): stop retry task #88

merged 1 commit into from
Nov 20, 2022

Conversation

appleboy
Copy link
Member

fix #87

Signed-off-by: Bo-Yi.Wu appleboy.tw@gmail.com

#87

Signed-off-by: Bo-Yi.Wu <appleboy.tw@gmail.com>
@appleboy appleboy added the bug Something isn't working label Nov 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Merging #88 (7ccd809) into master (a8fae77) will increase coverage by 1.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   88.01%   89.10%   +1.08%     
==========================================
  Files           9        9              
  Lines         409      413       +4     
==========================================
+ Hits          360      368       +8     
+ Misses         44       40       -4     
  Partials        5        5              
Flag Coverage Δ
go-1.18 89.10% <100.00%> (+1.08%) ⬆️
go-1.19 89.10% <100.00%> (+1.08%) ⬆️
ubuntu-latest 89.10% <100.00%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consumer.go 85.98% <100.00%> (+0.54%) ⬆️
worker_message.go 65.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appleboy appleboy changed the title fix(consumer): stop retry task when shutdown the service or timeout fix(consumer): stop retry task Nov 20, 2022
@appleboy appleboy merged commit d851d66 into master Nov 20, 2022
@appleboy appleboy deleted the retry2 branch November 20, 2022 03:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop retry task when shutdown the service or timeout.
2 participants