Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

increment CI go versions from 1.8.x/1.9.x/tip to 1.9.x/1.10.x/tip #1620

Merged
merged 1 commit into from
Feb 19, 2018
Merged

increment CI go versions from 1.8.x/1.9.x/tip to 1.9.x/1.10.x/tip #1620

merged 1 commit into from
Feb 19, 2018

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Feb 2, 2018

What does this do / why do we need it?

This PR increments the go versions for Travis and AppVeyor. 1.10 is only on release candidate 1, but is expected this month. I don't know if Travis/Gimme will route 1.10.x to 1.10rc1, but in case it does and this turns green: Don't merge until 1.10 is officially released!.

  • Changelog
  • Simpler appveyor.yml init?

@jmank88 jmank88 requested a review from sdboyer as a code owner February 2, 2018 20:36
@jmank88
Copy link
Collaborator Author

jmank88 commented Feb 2, 2018

Travis: I don't have any idea what to do with '1.10.x'. and it fell back to 1.7.4

@@ -9,7 +9,7 @@ clone_folder: c:\gopath\src\github.com\golang\dep
environment:
GOPATH: c:\gopath
DEPTESTBYPASS501: 1
GOVERSION: 1.8
GOVERSION: 1.9

init:
- git config --global core.autocrlf input
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the end of this script can now change from:
('go list github.com/golang/dep/... ^| find /i /v "/vendor/"')
to:
('go list github.com/golang/dep/...')

@jmank88
Copy link
Collaborator Author

jmank88 commented Feb 17, 2018

1.10 is out, but still waiting for them to support a.b.x like last cycle: #714 (comment)

Alternatively, we can do "1.10" for now, and change it later.

@jmank88
Copy link
Collaborator Author

jmank88 commented Feb 18, 2018

Blocked on travis-ci/gimme#130

Copy link
Collaborator

@ibrasho ibrasho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrasho
Copy link
Collaborator

ibrasho commented Feb 19, 2018

Can we switch to '1.10' instead of 1.10.x (until travis-ci/gimme#130 is resolved)?

@ibrasho
Copy link
Collaborator

ibrasho commented Feb 19, 2018

What's the difference between '1.10' and 1.10.x? (They should select the same version, no?)

@jmank88
Copy link
Collaborator Author

jmank88 commented Feb 19, 2018

No difference. Just avoids an extra future PR for a theoretical 1.10.1. Last cycle they fixed 1.9.x quick, so I was holding out, but I'll just change it now.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants