Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

x/tools: unified and longest builds are failing on the constraints package #48595

Open
findleyr opened this issue Sep 24, 2021 · 5 comments
Open

x/tools: unified and longest builds are failing on the constraints package #48595

findleyr opened this issue Sep 24, 2021 · 5 comments
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Member

As of https://golang.org/cl/349709, which introduced the constraints package, the x/tools unified and longtest builders are failing, though in different ways.

Longtest builders are failing in go/ssa:
https://build.golang.org/log/5352d2134bdc9df4bef4a9e3dee22cc99d443e70
Perhaps it would suffice to skip standard library packages that use type parameters, for now.

Unified builders are failing in gcimporter: https://build.golang.org/log/5cdff1e5c507144f74953000b0c7335a32ea0587

The latter (unified) is a TryBot for x/tools, so should be fixed soon; I will take a look at it tomorrow.

CC @mdempsky @timothy-king @ianlancetaylor @griesemer
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 24, 2021
@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2021
@cuonglm

This comment has been minimized.

# to view
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/352051 mentions this issue: go/ssa: skip the "constraints" package in TestStdlib

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/352050 mentions this issue: go/internal/gcimporter: temporarily skip the contraints package on the

gopherbot pushed a commit to golang/tools that referenced this issue Sep 24, 2021
@findleyr
go/internal/gcimporter: temporarily skip the contraints package on the
e1e06b8 
unified builder

Temporary work-around to fix TryBots until the failure can be
investigated.

Updates golang/go#48595

Change-Id: Ifbc27fc4551195bd9c7427bab7a79076c6ba6392
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352050
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopherbot pushed a commit to golang/tools that referenced this issue Sep 24, 2021
@findleyr
go/ssa: skip the "constraints" package in TestStdlib
939195f 
go/ssa doesn't yet support generics, so the "constraints" package causes
this test to fail.

Updates golang/go#48595

Change-Id: I11c5a944bffba0c0398cd48ffca5d80fbede4332
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352051
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@zpavlinovic zpavlinovic added the Analysis Issues related to static analysis (vet, x/tools/go/analysis) label Sep 24, 2021
@zpavlinovic
Copy link
Contributor

Likely related #48525

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/352853 mentions this issue: go/internal/gcimporter: skip typeparam import tests on unified builders

gopherbot pushed a commit to golang/tools that referenced this issue Sep 28, 2021
@findleyr
go/internal/gcimporter: skip typeparam import tests on unified builders
da36f79 
CL 351855 introduced a typeparam test that imported the constraints
package. As reported in golang/go#48595, this package is currently
breaking with the unified export data format.

Updates golang/go#48595

Change-Id: I1b77955c767a2e890d8d8829cca6455a4e79c5ee
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352853
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 4, 2021
@bcmills bcmills mentioned this issue May 4, 2022
Closed
apstndb pushed a commit to apstndb/gotoolsdiff that referenced this issue Jan 11, 2025
@findleyr
go/internal/gcimporter: temporarily skip the contraints package on the
307d369 
unified builder

Temporary work-around to fix TryBots until the failure can be
investigated.

Updates golang/go#48595

Change-Id: Ifbc27fc4551195bd9c7427bab7a79076c6ba6392
Reviewed-on: https://go-review.googlesource.com/c/tools/+/352050
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@zpavlinovic @mknyszek @cuonglm @gopherbot @findleyr