Skip to content

runtime: TestRaceSignal failures #60316

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
gopherbot opened this issue May 20, 2023 · 5 comments
Open

runtime: TestRaceSignal failures #60316

gopherbot opened this issue May 20, 2023 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "runtime" && test == "TestRaceSignal"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRaceSignal (1.69s)
    crash_cgo_test.go:431: 
    crash_cgo_test.go:432: signal: child exited

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 20, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestRaceSignal"
2023-05-17 14:45 darwin-amd64-longtest go@1bb2f732 runtime.TestRaceSignal (log) 
--- FAIL: TestRaceSignal (1.69s)
    crash_cgo_test.go:431: 
    crash_cgo_test.go:432: signal: child exited

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 20, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestRaceSignal"
2023-05-20 21:12 darwin-amd64-longtest go@2ec648aa runtime.TestRaceSignal (log) 
--- FAIL: TestRaceSignal (2.43s)
    crash_cgo_test.go:431: 
    crash_cgo_test.go:432: signal: child exited

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 22, 2023

(attn @ianlancetaylor)

I'm not sure what's going on here. The docs for os/signal indicate that the Go runtime unblocks SIGCHLD, but as far as I can tell the default behavior of SIGCHLD is still to ignore the signal. I'm not sure where the non-default behavior (of terminating the process) is coming from.

@ianlancetaylor
Copy link
Member

I agree that this seems impossible. Sending CL 497055.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/497055 mentions this issue: runtime: treat TestRaceSignal as flaky on Darwin

gopherbot pushed a commit that referenced this issue May 22, 2023
@ianlancetaylor @gopherbot
runtime: treat TestRaceSignal as flaky on Darwin
b66474e 
It should be impossible for the program to exit with SIGCHLD,
but it happens occasionally. Skip the test on Darwin.

For #60316

Change-Id: Idc9d89838e73f077afc42a9703554d61ac7a0069
Reviewed-on: https://go-review.googlesource.com/c/go/+/497055
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@mknyszek mknyszek added this to the Go1.21 milestone May 24, 2023
@mknyszek mknyszek modified the milestones: Go1.21, Backlog May 24, 2023
@bcmills bcmills mentioned this issue Jan 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mknyszek @ianlancetaylor @bcmills @gopherbot