-
Notifications
You must be signed in to change notification settings - Fork 18k
syscall: ignore O_DIRECTORY on Windows for js/wasm #72893
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: ae56ed0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/658295. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-21T13:53:04Z","revision":"287564973c5bad71815dff720f4977a9bd4ca58d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/658295. |
Updates #71758
Due to CL 588915, opening folders will always fail
when wasm is running on a Windows host.
A common use case is to write coverage files in unit tests.
Since we'll check isDirectory later, this shouldn't affect functionality.