cmd/gomobile: improve support for macOS and Catalyst #70

ydnar · 2021-07-14T22:36:57Z

This is is a follow-up from my previous PR (#65). It makes gomobile
aware of GOOS=ios and adds support for specifying specific Apple
platforms, instead of overloading the "ios" platform.

Supported platforms: ios, iossimulator, macos, and maccatalyst

These can now be specified the -target argument to gomobile, e.g.:
gomobile build -target=ios,iossimulator,macos,maccatalyst

It preserves the current behavior of -target=ios, which will build for
ios and iossimulator on supported architectures (arm64 and amd64).

It adds platform-specific build tags so Go code can discriminate between
different Apple platforms like maccatalyst (UIKit on macOS).

This PR also fixes a number of broken tests.

TODO: cgo has a bug where c-archive builds targeting Catalyst will fail
unless -tags=ios is supplied. See https://golang.org/issues/47228

Fixes https://golang.org/issues/47212
Updates https://golang.org/issues/47228

ydnar · 2021-07-14T22:39:21Z

Working to fix bug noted here: golang/go#36856

cc @hajimehoshi

gopherbot · 2021-07-14T22:41:26Z

This PR (HEAD: c7287ff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T01:49:08Z

Message from Hajime Hoshi:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T01:53:56Z

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T01:58:38Z

Message from Go Bot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T02:01:05Z

Message from Hajime Hoshi:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T03:21:25Z

Message from Randy Reddig:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T03:25:57Z

Message from Randy Reddig:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T03:44:34Z

This PR (HEAD: 9444da2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T04:11:57Z

Message from Hajime Hoshi:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T04:28:23Z

Message from Randy Reddig:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T04:41:18Z

Message from Hajime Hoshi:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T05:10:13Z

Message from Randy Reddig:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T05:12:46Z

This PR (HEAD: 8b6abc2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T05:21:12Z

Message from Hajime Hoshi:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T05:29:35Z

This PR (HEAD: 5527f9f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T05:39:51Z

Message from Randy Reddig:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-15T20:05:03Z

This PR (HEAD: 77eab9e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T20:54:46Z

This PR (HEAD: 708f5c6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T21:33:29Z

This PR (HEAD: 59bb063) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-15T21:40:50Z

Message from Randy Reddig:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-16T15:43:03Z

This PR (HEAD: 2f07876) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

google-cla · 2021-07-16T15:43:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-16T23:14:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-16T23:50:26Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

gopherbot · 2021-09-15T17:08:23Z

Message from Randy Reddig:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T00:48:01Z

Message from Hyang-Ah Hana Kim:

Patch Set 26: Run-TryBot+1 Code-Review+2 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T00:53:04Z

Message from Go Bot:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T01:01:33Z

Message from Go Bot:

Patch Set 26: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T01:01:34Z

Message from Randy Reddig:

Patch Set 26:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T01:14:14Z

Message from Hajime Hoshi:

Patch Set 26: Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

CL feedback

gopherbot · 2021-09-16T02:59:17Z

This PR (HEAD: 4ca2ca5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

…rk files

This is the minimal change to enable default support for Ivy on macOS via Mac Catalyst.

gopherbot · 2021-09-16T04:56:01Z

This PR (HEAD: b08c472) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-16T05:04:54Z

Message from Randy Reddig:

Patch Set 27:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T14:17:56Z

Message from Hajime Hoshi:

Patch Set 28: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T14:23:26Z

Message from Go Bot:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T18:31:55Z

Message from Hyang-Ah Hana Kim:

Patch Set 28: Code-Review+2 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:10:10Z

Message from Go Bot:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:10:11Z

Message from Go Bot:

Patch Set 28: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T22:56:43Z

Message from Randy Reddig:

Patch Set 28:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

CL feedback: https://go-review.googlesource.com/c/mobile/+/334689/28/example/bind/ios/README#1 New CL: golang#72

gopherbot · 2021-09-16T23:09:49Z

This PR (HEAD: 01ab28e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/334689 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-16T23:12:29Z

Message from Randy Reddig:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/334689.
After addressing review feedback, remember to publish your drafts!

This is is a follow-up from my previous PR (#65). It makes gomobile aware of GOOS=ios and adds support for specifying specific Apple platforms, instead of overloading the "ios" platform. Supported platforms: ios, iossimulator, macos, and maccatalyst These can now be specified the -target argument to gomobile, e.g.: gomobile build -target=ios,iossimulator,macos,maccatalyst It preserves the current behavior of -target=ios, which will build for ios and iossimulator on supported architectures (arm64 and amd64). It adds platform-specific build tags so Go code can discriminate between different Apple platforms like maccatalyst (UIKit on macOS). This PR also fixes a number of broken tests. TODO: cgo has a bug where c-archive builds targeting Catalyst will fail unless -tags=ios is supplied. See https://golang.org/issues/47228 Fixes https://golang.org/issues/47212 Updates https://golang.org/issues/47228 Change-Id: Ib1a2f5302c5edd0704c13ffbe8f4061211f50d4e GitHub-Last-Rev: 01ab28e GitHub-Pull-Request: #70 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/334689 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hajime Hoshi <hajimehoshi@gmail.com>

gopherbot · 2021-09-17T18:59:21Z

This PR is being closed because golang.org/cl/334689 has been merged.

https://golang.org/cl/334689 has been merged. See golang/mobile#70.

This breaks out the Swift Package Manager example from golang/mobile#71 into a separate repo. See https://golang.org/cl/350150 for additional info. Depends on https://golang.org/cl/334689 (golang/mobile#70).

google-cla bot added the cla: yes label Jul 14, 2021

iamcalledrob mentioned this pull request Jul 14, 2021

x/mobile: gomobile bind is ignoring target architecture parameter golang/go#47212

Closed

ydnar changed the title ~~cmd/gomobile: support GOOS=ios~~ cmd/gomobile: improve support for macOS and Catalyst Jul 15, 2021

google-cla bot added cla: no and removed cla: yes labels Jul 16, 2021

ydnar mentioned this pull request Sep 15, 2021

example: add Swift Package Manager example #71

Closed

ydnar added 2 commits September 15, 2021 19:57

.gitignore: remove .build for SPM

fe18852

cmd/gomobile: remove orderedSet

4ca2ca5

CL feedback

ydnar added 3 commits September 15, 2021 21:42

.gitignore: ignore Xcode user configuration files

58248db

example/ivy/ios: update README and Xcode project to support xcframewo…

9e5287b

…rk files

example/ivy/ios: support maccatalyst

b08c472

This is the minimal change to enable default support for Ivy on macOS via Mac Catalyst.

.gitignore, example/{bind,ivy}: revert to master

01ab28e

CL feedback: https://go-review.googlesource.com/c/mobile/+/334689/28/example/bind/ios/README#1 New CL: golang#72

gopherbot closed this Sep 17, 2021

ydnar added a commit to alta/quic-go-mobile-example that referenced this pull request Sep 17, 2021

go.{mod,sum}: update to current golang.org/x/mobile

a9c1169

https://golang.org/cl/334689 has been merged. See golang/mobile#70.

ydnar mentioned this pull request Sep 18, 2021

x/mobile: enable building frameworks for Catalyst golang/go#36856

Closed

cmd/gomobile: improve support for macOS and Catalyst #70

cmd/gomobile: improve support for macOS and Catalyst #70

Conversation

ydnar commented Jul 14, 2021 • edited Loading

ydnar commented Jul 14, 2021

gopherbot commented Jul 14, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 15, 2021

gopherbot commented Jul 16, 2021

google-cla bot commented Jul 16, 2021

google-cla bot commented Jul 16, 2021

google-cla bot commented Jul 16, 2021

gopherbot commented Sep 15, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 16, 2021

gopherbot commented Sep 17, 2021

ydnar commented Jul 14, 2021 •

edited

Loading