This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
add benchmark for parse file #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, we should get this integrated into our CI eventually. |
codyoss
approved these changes
Dec 27, 2019
|
created #373 |
codyoss
reviewed
Dec 27, 2019
| @@ -106,3 +106,10 @@ func checkGreeterImports(t *testing.T, imports map[string]string) { | |||
| t.Errorf("Expected import not to have key \"v1\"") | |||
| } | |||
| } | |||
|
|
|||
| func Benchmark_parseFile(b *testing.B) { | |||
There was a problem hiding this comment.
Suggested change
| func Benchmark_parseFile(b *testing.B) { | |
| func BenchmarkParseFile(b *testing.B) { |
nit: naming
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a basic benchmark test for
mockgenparseFileso we can compare performance changes between versions.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes