Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

sort methods on the mock implementation alphabetically #500

Merged
merged 1 commit into from
Dec 10, 2020
Merged

sort methods on the mock implementation alphabetically #500

merged 1 commit into from
Dec 10, 2020

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Nov 4, 2020

Fixes #499.

Description

Sorting the methods by name will make sure that their order is consistent in source and reflect mode.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Updated the tests, but not sure how to test this without writing a parser for the generated mock files.

Reviewer Notes

  • The code flow looks good.
  • Tests added.

@marten-seemann marten-seemann changed the title alphabetically sort methods on the mock implementation sort methods on the mock implementation alphabetically Nov 4, 2020
@marten-seemann
Copy link
Contributor Author

@codyoss Any thoughts on this PR?

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent order of methods on the mock interface between source and reflect mode
2 participants