Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Don't error out for variadic functions in Do/DoReturn #601

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

joshblum
Copy link
Contributor

@joshblum joshblum commented Dec 2, 2021

Addresses #600

@joshblum
Copy link
Contributor Author

joshblum commented Dec 2, 2021

@googlebot I signed it!

@codyoss
Copy link
Member

codyoss commented Dec 30, 2021

Discussing options on issue. Holding review for now.

@joshblum
Copy link
Contributor Author

joshblum commented Jan 5, 2022

@codyoss updated the error messaging here, happy to change the copy to what you think is most clear

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing!

gomock/call.go Outdated Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss enabled auto-merge (squash) January 7, 2022 20:19
@codyoss codyoss merged commit 96d9cb5 into golang:master Jan 7, 2022
@joshblum joshblum deleted the joshblum/do-arg branch January 7, 2022 23:45
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants