Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

design: add proposal for parameterized generic array sizes #33

Closed

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Feb 13, 2021

Detailed proposal for golang/go#44253.

@google-cla
Copy link

google-cla bot commented Feb 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 13, 2021
@ajwerner ajwerner force-pushed the ajwerner/generic-array-sizes branch from 1ac6b87 to 58cbf07 Compare February 13, 2021 21:11
@google-cla
Copy link

google-cla bot commented Feb 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ajwerner ajwerner force-pushed the ajwerner/generic-array-sizes branch from 58cbf07 to c3ddb0e Compare February 15, 2021 15:26
@google-cla
Copy link

google-cla bot commented Feb 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ajwerner
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 12, 2021
@gopherbot
Copy link

This PR (HEAD: c3ddb0e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/301290 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/301290.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301290.
After addressing review feedback, remember to publish your drafts!

@ajwerner ajwerner force-pushed the ajwerner/generic-array-sizes branch from c3ddb0e to 8e3bc88 Compare March 16, 2021 04:20
@gopherbot
Copy link

This PR (HEAD: 8e3bc88) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/301290 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@ajwerner ajwerner changed the title Add proposal for parameterized generic array sizes design: add proposal for parameterized generic array sizes Mar 16, 2021
@gopherbot
Copy link

Message from Andrew Werner:

Patch Set 2:

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301290.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 16, 2021
Detailed proposal for golang/go#44253.

Change-Id: I9e37363a4d5c41de100def1222d50ff6ad09d078
GitHub-Last-Rev: 8e3bc88
GitHub-Pull-Request: #33
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/301290
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/301290 has been merged.

@gopherbot gopherbot closed this Mar 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants