Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

go.mod: set go version to go1.9 #1055

Merged
merged 1 commit into from
Mar 12, 2020
Merged

go.mod: set go version to go1.9 #1055

merged 1 commit into from
Mar 12, 2020

Conversation

neild
Copy link
Contributor

@neild neild commented Mar 12, 2020

No description provided.

@neild neild requested a review from dsnet March 12, 2020 21:42
@neild neild merged commit 8466869 into golang:master Mar 12, 2020
@puellanivis
Copy link
Collaborator

What does this even do?

@neild
Copy link
Contributor Author

neild commented Mar 13, 2020

Apparently causes test failures in modules that depend on this one when using older Go compiler versions.

To be honest, I don't understand the exact effects of the Go version statement in go.mod at all. However, since we have an explicit goal of supporting Go 1.9, setting the version to that seems reasonable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dsnet dsnet dsnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neild @puellanivis @dsnet