Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

jsonpb: fix a confusing error message #1125

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

ijschwabacher
Copy link
Contributor

Because in is a []byte, as written this prints a list of integers instead of the unrecognized enum value.

Because `in` is a []byte, as written this prints a list of integers instead of the unrecognized enum value.
@dsnet dsnet changed the title Fix a confusing error message. jsonpb: fix a confusing error message May 11, 2020
@dsnet
Copy link
Member

dsnet commented May 11, 2020

Bug fix approved since it fixes a regression relative to v1.3.5. See

return fmt.Errorf("unknown value %q for enum %s", s, prop.Enum)

@dsnet dsnet merged commit 00998c7 into golang:master May 11, 2020
This was referenced Mar 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants