-
Notifications
You must be signed in to change notification settings - Fork 157
Add recover protection to Go method #12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 62ef034) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sync/+/348889 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/348889. |
Message from Bryan C. Mills: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/348889. |
Message from 叶子杰: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/348889. |
A Goroutine without recover protection will panic if something wrong happended, so I add recover to Go().
PTAL, thanks :)