-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
windows: correctly generate GetAce syscall #205
Conversation
This PR (HEAD: bda4500) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599295. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Ayman Bagabas: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from qiu laidongfeng2: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-19T04:29:26Z","revision":"d6a2de4562db752af0e35e31f35b2d4ddc02ba81"} Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from qiu laidongfeng2: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_sys-go1.23-windows-amd64 has failed with summary (view all results):
Build or test failure, click here for results. Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
bda4500
to
40cf750
Compare
This PR (HEAD: 40cf750) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599295. Important tips:
|
Message from Ayman Bagabas: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
GetAce expects a failretval==0, and we shouldn't call GetLastError on error. Fixes golang#191 Updates golang#191
Message from Alex Brainman: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Alex Brainman: Patch Set 3: -Run-TryBot Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-20T04:06:46Z","revision":"4224fecbc7fe7a95780b2189f618ccc9257e8a15"} Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Alex Brainman: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Alex Brainman: Patch Set 3: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-21T02:14:54Z","revision":"4224fecbc7fe7a95780b2189f618ccc9257e8a15"} Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/599295. |
GetAce expects a failretval==0, and we shouldn't call GetLastError on error. For golang/go#66850 Change-Id: I812d71b066d56e8285324e70b8b5b5fb42b5ce35 GitHub-Last-Rev: 40cf750 GitHub-Pull-Request: #205 Reviewed-on: https://go-review.googlesource.com/c/sys/+/599295 Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
This PR is being closed because golang.org/cl/599295 has been merged. |
GetAce expects a failretval==0, and we shouldn't call GetLastError on
error.
For golang/go#66850