Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

unix: update z/OS implementation of fcntl and mmap #216

Closed
wants to merge 1 commit into from
Closed

unix: update z/OS implementation of fcntl and mmap #216

wants to merge 1 commit into from

Conversation

jlee3227
Copy link
Contributor

@jlee3227 jlee3227 commented Sep 3, 2024 •
edited by dmitshur
Loading

  • Add a wrapper function around fcntl to handle different operation
    types and new fcntl implementation that accepts uintptr as an arg.
  • Add support for calling mmap/munmap with address pointers.
  • Add accompanying tests for new functions.

@jlee3227
unix: Update z/OS implementation of fcntl and mmap
07e32a4 
- Adds a wrapper function around fcntl to handle different operation types
and new fcntl implementation that accepts uintptr as an arg
- Adds support for calling mmap/munmap with address pointers
- Adds accompanying tests for new functions
@gopherbot
Copy link
Contributor

This PR (HEAD: 07e32a4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/610296.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bill O'Farrell:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-24T23:57:38Z","revision":"dcdefeaec23009a98719e3a7b8f3005af0b2213d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_sys-gotip-windows-amd64 has failed with summary (view all results):

Build or test failure, click here for results.

To reproduce, try gomote repro 8733151992568533185.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-25T00:00:28Z","revision":"a2a1613a93b1f0a20580ebbf5f8ade7bc320aa49"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from bcd a:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title unix: Update z/OS implementation of fcntl and mmap unix: update z/OS implementation of fcntl and mmap Oct 25, 2024
gopherbot pushed a commit that referenced this pull request Oct 25, 2024
@jlee3227 @gopherbot
unix: update z/OS implementation of fcntl and mmap
123459f 
- Add a wrapper function around fcntl to handle different operation
  types and new fcntl implementation that accepts uintptr as an arg.
- Add support for calling mmap/munmap with address pointers.
- Add accompanying tests for new functions.

Change-Id: If5e77aa4cf2cccfd431de4f3bd0c5014a761e167
GitHub-Last-Rev: 07e32a4
GitHub-Pull-Request: #216
Reviewed-on: https://go-review.googlesource.com/c/sys/+/610296
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610296.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/610296 has been merged.

@gopherbot gopherbot closed this Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlee3227 @gopherbot