-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
windows: update NewLazyDLL, LoadDLL docs to point to NewLazySystemDLL #240
Conversation
Point users to the NewLazySystemDLL utility that was added in CL 21592.
This PR (HEAD: 27e91d8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/638715. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Addressing the review comment.
Message from Jorropo: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T20:30:57Z","revision":"15a2d27f63c191bcc56654e646705985f3345645"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
This PR (HEAD: 1fe36ed) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/638715. Important tips:
|
Message from Sebastiaan van Stijn: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 3: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T20:46:14Z","revision":"f749b01f6663796ac2be812387ad0d52da143c3a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 3: Auto-Submit+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 3: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T20:52:54Z","revision":"f749b01f6663796ac2be812387ad0d52da143c3a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Jorropo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-25T23:59:42Z","revision":"f749b01f6663796ac2be812387ad0d52da143c3a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638715. |
Point users to the NewLazySystemDLL utility that was added in CL 21592. Change-Id: I5fddd927fe6628f06a6266b225949c4227fb79f1 GitHub-Last-Rev: 1fe36ed GitHub-Pull-Request: #240 Reviewed-on: https://go-review.googlesource.com/c/sys/+/638715 Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/638715 has been merged. |
Point users to the NewLazySystemDLL utility that was added in CL 21592.